If you ask someone “What have you done?” and “What did you do?”, the two questions can look almost identical. Both ask about a person’s actions, and both are grammatically correct.
But they do not always communicate the same idea.
The main difference is tense and perspective. “What have you done?” uses the present perfect tense, which connects a past action to the present. “
What did you do?” uses the simple past tense, which normally asks about a completed action or event in the past.
That small difference can change the meaning, timing, and even emotional tone of the question.
For example:
- What have you done? → What action have you completed, and what is the result or relevance now?
- What did you do? → What action did you perform at a particular or understood time in the past?
Sometimes both questions can refer to the same action. The speaker’s focus, however, is different.
Quick Answer
“What have you done?” is present perfect. It usually focuses on a past action that has a connection with the present, especially a recent action or its current result.
“What did you do?” is simple past. It focuses on a completed past action, often connected to a finished time or past event.
Both are correct. Use “what have you done?” when the present result or current situation matters; use “what did you do?” when you are asking about a completed past event.
Easy rule:
Present result → “What have you done?”
Finished past event → “What did you do?”
What Is the Difference Between “What Have You Done” and “What Did You Do”?
The most important difference is the tense.
| Feature | What have you done? | What did you do? |
|---|---|---|
| Tense | Present perfect | Simple past |
| Structure | What + have + subject + past participle | What + did + subject + base verb |
| Main focus | Past action connected to the present | Completed past action |
| Time | Often recent or unspecified | Usually a definite or understood past time |
| Current result | Often important | Usually not the main focus |
| Finished-time expressions | Generally not used | Common |
| Example | What have you done to the computer? | What did you do yesterday? |
| Typical setting | Recent event, present consequence | Past event, story, routine |
| Emotional tone | Can sound surprised or alarmed | Usually more neutral |
| Correct? | Yes | Yes |
The distinction becomes clearer when you look at the complete sentences.
What have you done to my phone?
The speaker can see that something is wrong with the phone now. The question focuses on the action and its present consequence.
What did you do to my phone yesterday?
Here, the speaker is asking about a past event, with “yesterday” identifying a completed period.
Neither sentence is inherently better. The appropriate choice depends on what the speaker wants to communicate.
What Does “What Have You Done?” Mean?
“What have you done?” is formed with the present perfect tense:
have + past participle
In this question:
- have = present-tense auxiliary verb
- you = subject
- done = past participle of do
The question asks about an action that happened before now but has some connection with the present.
Example
Imagine you enter a room and discover that the wall has been painted bright green.
You might say:
What have you done to the wall?
You are not necessarily interested in the exact time the person painted it. You are reacting to the current result: the wall is now green.
Compare:
What did you do to the wall?
This sounds more like a question about a completed past action. It could be asking what the person did to the wall at a particular point in the past.
Common meanings of “What have you done?”
The present perfect question can ask:
- What action have you just completed?
- What action has produced this result?
- What have you done up to now?
- What action have you taken in the situation?
For example:
What have you done with my keys?
What have you done to the computer?
What have you done to fix the problem?
What have you done since I left?
The exact meaning depends on the context.
What Does “What Did You Do?” Mean?
“What did you do?” uses the simple past tense.
Its structure is:
what + did + subject + base verb
Notice an important grammar rule:
What did you do?
Not:
❌ What did you did?
After did, the main verb returns to its base form.
So:
- did + do
- did + go
- did + see
- did + write
- did + make
Examples
What did you do yesterday?
What did you do after school?
What did you do when you got home?
What did you do at the meeting?
What did you do last weekend?
These questions normally concern actions completed in the past.
The speaker may have a specific past time in mind, even when the time is not stated.
For example:
A: You looked upset yesterday. What did you do after work?
B: I went home and watched a movie.
The question concerns a completed period: after work yesterday.
“What Have You Done?” vs “What Did You Do?” Grammar
This is fundamentally a present perfect vs simple past question.
Present Perfect: “Have You Done?”
The present perfect is formed using:
have/has + past participle
Examples:
- I have done
- you have done
- we have done
- they have done
- he has done
- she has done
In the question:
What have you done?
The auxiliary have comes before the subject, and done is the past participle.
Simple Past: “Did You Do?”
The simple past question uses:
did + subject + base verb
Therefore:
What did you do?
The verb after did must be do, not did or done.
Compare the structures
Present perfect:
What + have + you + done?
Simple past:
What + did + you + do?
This difference is small in form but significant in meaning.
Why Is “Done” Used After “Have”?
This is one of the most important grammar points in the comparison.
Done is the past participle of do.
The present perfect requires a past participle:
I have done my work.
She has done the assignment.
What have you done?
You cannot normally replace done with the simple past form after have.
❌ What have you did?
❌ What have you do?
✅ What have you done?
By contrast, did is used as the auxiliary in the simple past question:
What did you do?
Because did already carries the past tense, the main verb remains in its base form.
When Should You Use “What Have You Done?”
Use “What have you done?” when the past action is important because of its connection with the present.
1. When the result is visible now
The kitchen is completely different. What have you done?
The speaker sees a present result.
2. When something has just happened
The alarm is ringing. What have you done?
The action is recent, and its consequences are happening now.
3. When the exact time is unimportant
What have you done to improve your English?
The question asks about actions taken up to the present rather than one specific past event.
4. When discussing achievements or actions up to now
What have you done so far?
This asks about progress from the beginning of a period until now.
5. When reacting emotionally
Oh no! What have you done?
This can express surprise, shock, concern, or anger.
Importantly, “what have you done?” does not automatically mean the speaker is angry. Intonation and context determine the emotional meaning.
When Should You Use “What Did You Do?”
Use “What did you do?” when asking about a completed event in the past.
1. With a finished time
What did you do yesterday?
What did you do last night?
What did you do last summer?
What did you do in 2024?
These refer to completed periods.
2. When discussing a past event
What did you do after the meeting?
What did you do when the teacher arrived?
3. When telling a story
You said something unusual happened. What did you do next?
The speaker is moving through a past sequence.
4. When asking about someone’s past behavior
What did you do when you first started working there?
The focus is on a past period.
5. When the present result is not the main concern
What did you do at the party?
The speaker simply wants information about the past event.
Can “What Have You Done?” and “What Did You Do?” Mean the Same Thing?
Yes, in some contexts they can refer to the same action, but they frame that action differently.
Consider this situation:
Someone has broken a window.
You could ask:
What have you done?
This emphasizes the situation now. The broken window is a current consequence.
You could also ask:
What did you do?
This asks about the person’s past action.
The difference is therefore not always about which action happened. It is often about how the speaker views that action in relation to time.
Compare:
What have you done to my laptop?
Focus: the laptop’s condition now.
What did you do to my laptop yesterday?
Focus: the action that happened yesterday.
This is why translating both questions simply as “آپ نے کیا کیا؟” or “تم نے کیا کیا؟” can hide an important English tense distinction.
Why “What Have You Done?” Can Sound More Emotional
One interesting feature of this expression is its emotional potential.
Imagine someone walks into a room and sees a huge mess.
They say:
What have you done?!
The present perfect makes the speaker’s attention strongly connected to the current situation.
The same person could say:
What did you do?
That can sound much more neutral.
However, grammar alone does not determine emotion.
Compare:
What have you done to solve the problem?
This can be completely neutral.
And:
What did you do to my computer?!
This can sound extremely angry.
So it is better to say:
“What have you done?” often has a strong emotional use, but the tense itself does not make the sentence angry. Context and intonation matter.
Present Perfect vs Simple Past: The Core Rule
A useful way to understand the difference is to imagine two timelines.
“What have you done?”
Past action → NOW
The action happened before the present, but the speaker connects it to now.
“What did you do?”
Past action → FINISHED PAST
The speaker treats the action as part of a completed past event or period.
This does not mean every present-perfect action happened only a few seconds ago. The present perfect can describe experiences or actions during a period that continues to the present.
For example:
What have you done today?
If it is still today, the period may be considered unfinished.
Compare:
What did you do yesterday?
Yesterday is finished.
Time Expressions: A Major Difference
Time expressions often help you choose the correct tense.
Common with “What did you do?”
- yesterday
- last night
- last week
- last year
- two days ago
- in 2020
- when I was a child
- after the meeting
- during the holiday
Examples:
What did you do yesterday?
What did you do last weekend?
What did you do two hours ago?
Common with “What have you done?”
- today
- this week
- this month
- so far
- already
- recently
- just
- ever
- never
- yet
Examples:
What have you done today?
What have you done so far?
What have you done recently?
What have you done with the money?
There is an important qualification: English usage varies by dialect and context, especially with words such as just, already, and yet. American English commonly uses the simple past in some contexts where British English traditionally favors the present perfect.
American English vs British English
Both American English and British English use the present perfect and simple past.
The basic grammatical distinction remains the same.
However, American English often allows the simple past in conversational contexts where British English is more likely to use the present perfect.
For example, American speakers may naturally say:
Did you eat yet?
British English traditionally prefers:
Have you eaten yet?
This does not mean that American English has abandoned the present perfect. It remains a normal and productive tense in American English.
Likewise, “What have you done?” and “What did you do?” are both standard in both major varieties. The surrounding context determines the natural choice.
20+ Real-Life Examples of “What Have You Done?” and “What Did You Do?”
The easiest way to understand this difference is through real situations.
Everyday Conversation
1.
“Why is the TV not working?”
“I don’t know.”
“What have you done to it?”
The current condition of the TV matters.
2.
“You went to the store yesterday. What did you do afterward?”
The question refers to a completed past sequence.
Family Conversation
3.
“Why is the baby crying? What have you done?”
The present situation matters.
4.
“What did you do when your parents came home?”
The speaker asks about a past event.
School
5.
“Your project looks completely different. What have you done?”
The speaker sees the result now.
6.
“What did you do for your science project last semester?”
The question concerns a completed past period.
Work
7.
“The figures look much better. What have you done to improve them?”
The present result is important.
8.
“What did you do at yesterday’s client meeting?”
The meeting is a completed past event.
9.
“Could you tell me what you have done so far to resolve the issue?”
The writer is asking about progress up to now.
10.
“Could you explain what you did during the previous testing phase?”
The writer asks about a completed past phase.
Professional Writing
11.
“The report has changed considerably. What have you done to the original analysis?”
The current version is the focus.
12.
“What did you do after receiving the client’s feedback?”
The question concerns a completed past action.
Academic Context
13.
“What have you done to verify your results?”
The question concerns steps taken so far.
14.
“What did you do during the first stage of the experiment?”
The first stage is treated as a completed period.
Text Messages
15.
“Why is my account locked? What have you done?”
The current consequence matters.
16.
“Where did you go last night? What did you do?”
The speaker asks about a past evening.
Social Media
17.
“Your new video looks amazing. What have you done with the editing?”
The current result is visible.
18.
“What did you do during your trip to London?”
The trip is a completed past experience.
Daily Speaking
19.
“I can’t find my wallet. What have you done with it?”
The wallet’s present location matters.
20.
“What did you do with the old furniture?”
The question can concern a completed past action.
Recent Events
21.
“The computer has suddenly restarted. What have you done?”
The speaker is reacting to a current event.
22.
“The computer restarted yesterday. What did you do after that?”
The speaker is asking about a past event.
Personal Experience
23.
“What have you done to prepare for the interview?”
The preparation leading up to now is the focus.
24.
“What did you do to prepare for your interview last Monday?”
The preparation is associated with a completed past event.
Common Mistakes
Mistake 1: “What have you did?”
❌ What have you did?
This is incorrect because the present perfect requires the past participle.
✅ What have you done?
The forms are:
do → did → done
- do = base form
- did = simple past
- done = past participle
Mistake 2: “What did you done?”
❌ What did you done?
After did, use the base form.
✅ What did you do?
The auxiliary did already marks the past tense.
Mistake 3: Using present perfect with a finished past time
A learner may write:
❌ What have you done yesterday?
In standard English, a specific finished time such as yesterday normally calls for the simple past.
✅ What did you do yesterday?
Mistake 4: Assuming “have” always means possession
In “What have you done?”, have is not expressing possession.
It is an auxiliary verb used to form the present perfect.
Compare:
I have a car.
Here, have is a main verb.
I have finished my work.
Here, have is an auxiliary verb.
Mistake 5: Thinking one form is always more correct
Both questions are grammatically correct.
The mistake is choosing one simply because it “sounds more correct.”
The correct choice depends on:
- time reference
- current relevance
- context
- speaker intention
- regional usage
- conversational setting
“What Have You Done?” With “Just”
A particularly common construction is:
What have you just done?
This is natural when someone has completed an action moments ago.
For example:
What have you just done to the computer?
The speaker is responding to a recent action with a current consequence.
However, conversational English varies by region.
You may also hear:
What did you just do?
This is especially common in American English.
Both can be natural depending on dialect and context.
The important point is that “just” does not automatically make one tense universally correct.
“What Did You Do?” With “Yesterday”
This is one of the easiest cases.
What did you do yesterday? ✅
Because yesterday is a finished past time, the simple past is the natural choice.
The present perfect normally does not combine with a finished-time expression such as yesterday when the intention is to locate the event specifically in that completed period.
“What Have You Done Today?” vs “What Did You Do Today?”
This pair can confuse even advanced learners.
What have you done today?
This usually treats today as an unfinished period or focuses on what has happened so far.
What did you do today?
This can also occur, especially in conversational English, particularly when the speaker treats the relevant activities as a completed part of the day or is using regional conversational patterns.
So the distinction is not a mechanical rule where one tense is always possible and the other is never possible.
Context matters.
“What Have You Done With…” vs “What Did You Do With…”
The phrase “what have you done with…” is especially common when asking about the current location or condition of something.
What have you done with my keys?
This often means:
Where are my keys now?
Similarly:
What have you done with the documents?
The speaker may be asking where the documents are or what has happened to them.
By contrast:
What did you do with the documents?
This generally asks about a past action involving the documents.
For example:
What did you do with the documents after the meeting?
The added past-time context makes the simple past particularly natural.
“What Have You Done to…” vs “What Did You Do to…”
These forms can have noticeably different implications.
What have you done to…?
Often focuses on the current condition:
What have you done to my car?
The car is visibly different or damaged now.
What did you do to…?
Often focuses on the past action:
What did you do to my car yesterday?
The question asks what happened at that past time.
Again, context can make the two overlap.
Memory Trick
Use this simple formula:
HAVE = connection to NOW
Think:
What have you done? → What is the result now?
DID = finished PAST
Think:
What did you do? → What happened then?
Another quick trick:
Have → present connection
Did → completed past
If you can naturally add yesterday, last night, two days ago, or in 2023, the simple past is usually the better choice.
If you are talking about the result now, progress so far, or an unspecified past action connected to the present, the present perfect may be appropriate.
A Simple Decision Test
When you are unsure which question to use, ask yourself these questions:
- Am I asking about a finished past time?
Use “What did you do?” - Am I interested in the current result?
Use “What have you done?” - Did I mention “yesterday,” “last week,” or another finished time?
The simple past is usually appropriate. - Am I asking what someone has accomplished or done so far?
The present perfect is often appropriate. - Am I reacting to something that has just happened and is visible now?
The present perfect can be especially natural.
Quick Comparison Examples
| Situation | Natural question |
|---|---|
| You see a broken window now | What have you done? |
| You ask about yesterday | What did you do yesterday? |
| You want to know someone’s progress | What have you done so far? |
| You ask about a past meeting | What did you do at the meeting? |
| You see a changed computer | What have you done to the computer? |
| You ask about an action last night | What did you do last night? |
| You ask about preparation up to now | What have you done to prepare? |
| You ask about preparation for a past event | What did you do to prepare? |
Frequently Asked Questions
Is “What have you done?” grammatically correct?
Yes. “What have you done?” is a standard English question using the present perfect tense. It often asks about a past action that has relevance to the present.
Is “What did you do?” grammatically correct?
Yes. “What did you do?” is a standard simple past question. It normally asks about a completed action or event in the past.
Which is correct: “What have you done?” or “What did you do?”
Both are correct. They use different tenses and therefore can emphasize different time relationships. Use the present perfect when the action connects to the present; use the simple past for a completed past event.
Can I say “What did you do yesterday?”
Yes. This is the natural standard construction because yesterday refers to a finished past period.
Can I say “What have you done yesterday?”
In standard English, this is generally not the normal choice when yesterday refers to the completed day. Use:
What did you do yesterday?
Why do we say “What have you done” instead of “What have you did”?
Because the present perfect requires the past participle. The past participle of do is done.
have + done ✅
have + did ❌
Why do we say “What did you do” instead of “What did you done”?
Because did is the past-tense auxiliary, so the main verb must be in its base form.
did + do ✅
did + done ❌
Does “What have you done?” always sound angry?
No. It can sound surprised, worried, shocked, amused, or completely neutral. The emotional meaning depends heavily on context and intonation.
For example:
What have you done to improve the website?
is a neutral question.
But:
What have you done?!
can express alarm or anger.
Is “What have you done?” more British than “What did you do?”
No. Both forms are used in both British and American English. The broader difference is between present perfect and simple past, although the two varieties can differ in when conversational speakers choose one tense over the other.
What English Learners Should Remember
The most useful lesson is not to memorize a complicated list of grammar rules. Learn to recognize the speaker’s time perspective.
When the speaker looks from the past toward the present:
What have you done?
When the speaker looks back at a completed past event:
What did you do?
Compare these two examples:
The room is a mess. What have you done?
The speaker sees the mess now.
What did you do in your room yesterday?
The speaker asks about a completed past period.
That difference is the heart of the entire comparison.
Final Verdict
“What have you done?” and “What did you do?” are both correct English questions. Neither one is universally better.
Use “What have you done?” when you want to connect a past action with the present, especially when discussing a current result, recent action, progress, or an unspecified past action with present relevance.
Use “What did you do?” when you are asking about a completed action or event in the past, especially when a finished time such as yesterday, last night, last week, or in 2020 is involved.
The grammar can be remembered in one line:
What have you done? = What action has happened, and why does it matter now?
What did you do? = What action happened in the past?
And remember the two grammar patterns:
have + done → present perfect
did + do → simple past
So if someone asks, “What have you done?”, they are often looking at the present result of your action.
If they ask, “What did you do?”, they are usually asking you to describe a past action or event.
Once you understand that difference in perspective, choosing between the two becomes much easier.
Evan Bennett is a language enthusiast who writes simple, clear guides about word meanings, slang, phrases, and everyday expressions.
He helps readers understand modern language quickly with easy explanations and useful examples.